> On Nov. 2, 2014, 7:01 p.m., Bhushan Shah wrote: > > browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 > > <https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9> > > > > Don't use find_libarary as well as never hardcode locations. Instead > > use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example > > Ashish Bansal wrote: > Like this -> find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct > then it's okay because cmake is unable to find its path for me that's why I > hardcoded its path.
umm nope but like this, find_package(LibKGAPI2 REQUIRED) - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 ----------------------------------------------------------- On Oct. 28, 2014, 11:20 p.m., Ashish Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120855/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 11:20 p.m.) > > > Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu > Tushar, Sinny Kumari, and Sujith Haridasan. > > > Bugs: 336398 > http://bugs.kde.org/show_bug.cgi?id=336398 > > > Repository: plasma-mediacenter > > > Description > ------- > > Changed auth method from Client Login to OAuth using libkgapi2 > > > Diffs > ----- > > browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 > browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 > browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml > e8f97f7 > browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 > browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 > browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 > CMakeLists.txt abea259 > browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d > > Diff: https://git.reviewboard.kde.org/r/120855/diff/ > > > Testing > ------- > > Everything is working fine except that after successful login, user has to > press back to view all the albums. > > > Thanks, > > Ashish Bansal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
