Re: Review Request 120538: Update default applications in kickoff

2014-11-03 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- (Updated Nov. 3, 2014, 1:36 p.m.) Status -- This change has been mar

Re: Review Request 120538: Update default applications in kickoff

2014-11-03 Thread Eike Hein
> On Nov. 3, 2014, 9:56 a.m., Sebastian Kügler wrote: > > Can this RR be closed or abandoned? I kind of forgot what the result was, but I remember writing most of the Kicker patch and then abandoning it for $reasons ... I guess the idea was to implement it in kamd instead because of the kamd f

Re: Review Request 120538: Update default applications in kickoff

2014-11-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review69719 --- Can this RR be closed or abandoned? - Sebastian Kügler On O

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executa

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68140 --- Please hold off on committing this to the 5.1 branch until the

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Eike Hein
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executa

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Martin Klapetek
> On Oct. 9, 2014, 11:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by execut

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by executa

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Martin Klapetek
> On Oct. 9, 2014, 11:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. > > Sebastian Kügler wrote: > The default browser is known by execut

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68131 --- applets/kickoff/core/favoritesmodel.cpp

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68130 --- Ship it! Ship It! - Sebastian Kügler On Oct. 9, 2014, 8:41

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:37 a.m., Jonathan Riddell wrote: > > I'd also like to proposed changing kwrite to kate, the only difference > > seems to be the sidebar with tabs for open files, but all users have known > > how to use tabs for years No problem with that, and I think nowadays, they're in t

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Sebastian Kügler
> On Oct. 9, 2014, 9:06 a.m., Kai Uwe Broulik wrote: > > Can't this be deduced from the default browser or default application to > > handle text/html? That way it will always be the distribution's preferred > > browser. The default browser is known by executable name, so we'd still need to ge

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68113 --- I'd also like to proposed changing kwrite to kate, the only di

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Eike Hein
> On Oct. 9, 2014, 8:58 a.m., Jonathan Riddell wrote: > > discussion also at: > > https://forum.kde.org/viewtopic.php?f=285&t=123201 If this gets in a similar patch has to be written for Kicker, they should be in sync. - Eike --- This

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68111 --- Can't this be deduced from the default browser or default appl

Re: Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review68110 --- discussion also at: https://forum.kde.org/viewtopic.php?f=285&

Review Request 120538: Update default applications in kickoff

2014-10-09 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- Review request for Plasma. Repository: plasma-desktop Description -