Re: Review Request 119822: QScreen backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- (Updated Sept. 14, 2014, 10:16 p.m.) Status -- This change has been

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a Q

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a QS

Re: Review Request 119822: QScreen backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- (Updated Aug. 20, 2014, 4:35 p.m.) Review request for Plasma and Solid.

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 90 > > > > > > Q_FOREACH > > Martin Gräßlin wrote: > or instead of using Qt macros one could use what the languag

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 90 > > > > > > Q_FOREACH or instead of using Qt macros one could use what the language provides: for (const KScreen::

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a Q

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we c

Re: Review Request 119822: QScreen backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/#review64727 --- Besides the nitpits, here is a concern I have. KScreen is a l

Review Request 119822: QScreen backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- Review request for Plasma and Solid. Repository: libkscreen Description

Review Request 119822: QScreen backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- Review request for Plasma and Solid. Repository: libkscreen Description