Re: Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/ --- (Updated Aug. 5, 2014, 5:49 p.m.) Status -- This change has been mar

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/#review63873 --- Ship it! Been running it all day, including some monitor hotp

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-04 Thread Marco Martin
> On Aug. 4, 2014, 3:44 p.m., Marco Martin wrote: > > wasn't screenforitem introduced because window()->screen() then won't > > notice if the qwindow changes screen? > > did you test by dragging a dialog between screens if all still works > > correctly? > > Aleix Pol Gonzalez wrote: > Work

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-04 Thread David Edmundson
> On Aug. 4, 2014, 3:44 p.m., Marco Martin wrote: > > wasn't screenforitem introduced because window()->screen() then won't > > notice if the qwindow changes screen? > > did you test by dragging a dialog between screens if all still works > > correctly? > > Aleix Pol Gonzalez wrote: > Work

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-04 Thread Aleix Pol Gonzalez
> On Aug. 4, 2014, 3:44 p.m., Marco Martin wrote: > > wasn't screenforitem introduced because window()->screen() then won't > > notice if the qwindow changes screen? > > did you test by dragging a dialog between screens if all still works > > correctly? Works here, but then I'm on Qt 5.4. I'll

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/#review63795 --- wasn't screenforitem introduced because window()->screen() the

Review Request 119603: Use Qt API for figuring out the dialog screen

2014-08-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/ --- Review request for Plasma. Repository: plasma-framework Description ---