> On Aug. 4, 2014, 3:44 p.m., Marco Martin wrote: > > wasn't screenforitem introduced because window()->screen() then won't > > notice if the qwindow changes screen? > > did you test by dragging a dialog between screens if all still works > > correctly?
Works here, but then I'm on Qt 5.4. I'll poke David to test it. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/#review63795 ----------------------------------------------------------- On Aug. 4, 2014, 3:38 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119603/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 3:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > At the moment it's trying to translate the item position and iterating > through all screens, but we can get the screen through the item's window. > > > Diffs > ----- > > src/plasmaquick/dialog.cpp fb33ffa > > Diff: https://git.reviewboard.kde.org/r/119603/diff/ > > > Testing > ------- > > Tests pass, everything works without glitches (I used to have some, depending > on the screen configuration). > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
