Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread Marco Martin
> On July 28, 2014, 4:40 p.m., David Edmundson wrote: > > >The ugly thing here is that QtControls ToolButton doesn't have a flat > > >property, it should probably be upstreamed, at least for compatibility > > >with the qwidgets ToolButton > > > > I can't see a flat property on the widget's too

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63340 --- >The ugly thing here is that QtControls ToolButton doesn't hav

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- (Updated July 28, 2014, 3:50 p.m.) Status -- This change has been ma

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63337 --- Ship it! Ship It! - David Edmundson On July 25, 2014, 4:52

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- (Updated July 25, 2014, 4:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin
> On July 25, 2014, 3:57 p.m., Andrew Lake wrote: > > src/declarativeimports/plasmacomponents/qml/ToolButton.qml, line 30 > > > > > > Just curious, any reason to not use ToolButton here? > > > > http://qt

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63169 --- src/declarativeimports/plasmacomponents/qml/ToolButton.qml

Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor