----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63340 -----------------------------------------------------------
>The ugly thing here is that QtControls ToolButton doesn't have a flat >property, it should probably be upstreamed, at least for compatibility with >the qwidgets ToolButton I can't see a flat property on the widget's toolbutton. http://qt-project.org/doc/qt-5/qtoolbutton.html, which property are you thinking of? - David Edmundson On July 28, 2014, 3:50 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119464/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 3:50 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports ToolButton. > It's a different style than Button since it's way more complicated. > > The ugly thing here is that QtControls ToolButton doesn't have a flat > property, it should probably be upstreamed, at least for compatibility with > the qwidgets ToolButton > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml > 20caef6 > src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b > src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml > PRE-CREATION > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 > > Diff: https://git.reviewboard.kde.org/r/119464/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
