Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Heiko Becker
> On Juli 11, 2014, 10:19 vorm., Jonathan Riddell wrote: > > Submitted, but it would be great if you'd add this cmake module to > > extra-cmake-modules as currently it's duplicated several times Please see https://git.reviewboard.kde.org/r/119230/ - Heiko ---

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/#review62124 --- Submitted, but it would be great if you'd add this cmake modul

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/ --- (Updated July 11, 2014, 10:17 a.m.) Status -- This change has been m

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Eike Hein
> On July 11, 2014, 9:20 a.m., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday ac

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Eike Hein
> On July 11, 2014, 9:20 a.m., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday ac

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Heiko Becker
> On Juli 11, 2014, 9:20 vorm., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday a

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Eike Hein
> On July 11, 2014, 9:20 a.m., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday ac

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/#review62116 --- Ship it! My bad, I didn't realize it was needed. I did actual

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Heiko Becker
> On Juli 11, 2014, 8:48 vorm., Martin Gräßlin wrote: > > is it needed at all? I'm surprised that something in plasma-desktop would > > use OpenGL at all, might be just a copy-paste error. At least the cmake code claims folderplugin gets linked with OpenGLES (if it is found). The commit which

Re: Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/#review62114 --- is it needed at all? I'm surprised that something in plasma-de

Review Request 119227: Add FindOpenGLES

2014-07-11 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/ --- Review request for Plasma. Repository: plasma-desktop Description -