-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119227/#review62116
-----------------------------------------------------------

Ship it!


My bad, I didn't realize it was needed. I did actually ask a few people to 
review the CMake code this week, but they must have assumed it was there or 
dodn't realize either.

@Martin: You got to see the OpenGL code yesterday actually :).

- Eike Hein


On July 11, 2014, 8:12 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119227/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 8:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Otherwise I get OpenGLES not found messages if Qt is compiled with support 
> for OpenGLES.
> 
> 
> The actual cmake module is copied over from kwin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fd3680886b50527a0894b61d65d10eca665eec35 
>   cmake/modules/FindOpenGLES.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119227/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and installed.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to