Re: Review Request 118547: Expose Formats as singleton

2014-06-05 Thread David Edmundson
> On June 5, 2014, 3:44 a.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 40 > > > > > > Err no, this will fail when using formatRelativeDate and > > formatRelativeDateTime go

Re: Review Request 118547: Expose Formats as singleton

2014-06-04 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59261 --- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp

Re: Review Request 118547: Expose Formats as singleton

2014-06-04 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59256 --- Ship it! Makes sense and looks nice! - Mark Gaiser On June

Review Request 118547: Expose Formats as singleton

2014-06-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative