----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description ------- Expose Formats as singleton Formats is basically just a collection of invokable static methods. This saves creating a few objects and makes for a a nicer API. Without it you have to have a bit of code like: - KCoreAddons.Formats { - id: formats - } then do text:formats.formatData(...) in your labels this becomes now KCoreAddons.Format.formatData(...) Diffs ----- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 65dd75f Diff: https://git.reviewboard.kde.org/r/118547/diff/ Testing ------- Made the two changes needed in plasma-workspace. Everything seemed to be ok. Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel