Re: Review Request 118275: Remove duplicated code in showEvent and constructor

2015-09-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/ --- (Updated Sept. 2, 2015, 11:36 a.m.) Status -- This change has been d

Re: Review Request 118275: Remove duplicated code in showEvent and constructor

2014-05-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/#review58431 --- Looks good, but please test it thoroughly. Note that everythi

Re: Review Request 118275: Remove duplicated code in showEvent and constructor

2014-05-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/#review58365 --- flags and type might be needed in the show event. I recommend

Review Request 118275: Remove duplicated code in showEvent and constructor

2014-05-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/ --- Review request for Plasma. Repository: plasma-workspace Description ---