----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118275/ -----------------------------------------------------------
(Updated Sept. 2, 2015, 11:36 a.m.) Status ------ This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description ------- Remove duplicated code in showEvent and constructor Hiding a window doesn't delete it so we shouldn't have to set all these things again, but I'm not 100% confident enough to just push. Diffs ----- shell/panelconfigview.cpp b3bf598 Diff: https://git.reviewboard.kde.org/r/118275/diff/ Testing ------- Looks the same to me, but I'm not entirely sure what the shadows and blur etc. look like so I might be missing something. Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
