Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Eike Hein
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Eike Hein
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Marco Martin
On Friday 30 August 2013 13:44:35 Hugo Pereira Da Costa wrote: > Second: "support the lowest common denominator of QStyle that they both > follow even" I disagree, and besides, I believe this will simply not work. > It 'sort of does' in this specific case, but then q_object_cast is used all > over

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Christoph Feck
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
> On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: > > I respectfully disagree with the change. > > > > If I understand the descripion right, the only thing that matters for > > QtQuick is to change the default returned value (if all else fail) from 1 > > to FRAME_FRAMEWIDTH. Correct

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/#review38928 --- I respectfully disagree with the change. If I understand the d

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Aug. 30, 2013, 11:11 a.m.) Review request for Plasma and Hugo Per

Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- Review request for Plasma and Hugo Pereira Da Costa. Description ---