----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ -----------------------------------------------------------
Review request for Plasma and Hugo Pereira Da Costa. Description ------- Use a single frame width for all PM_DefaultFrameWidth The current code sets a width of 3 for all line edits, combo boxes and frames, otherwise it returns a width of 1. The QtQuickControls engine cannot qobject_cast() the widget so always return a frame width of 1 for qtquickcontrol line edits and combo boxes. This simplifies the code and solves that issue. I can think of no other way to resolve this without editing Qt, and even then it would be difficult to extend the PixelMetric enum without breaking compatibility. Note this is potentially a visual change in oxygen, however I have yet to see anything actually different. Diffs ----- kstyles/oxygen/oxygenmetrics.h 0643ae5b20d0c9efa328a87e08707cebaabf9f5e kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911 Diff: http://git.reviewboard.kde.org/r/112375/diff/ Testing ------- File Attachments ---------------- QML After http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png QML_Before http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png Normal oxygen demo http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
