Re: Review Request: use sqlite for storage

2010-10-01 Thread Marco Martin
> On 2010-10-01 17:13:46, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/private/storage.cpp, line 41 > > > > > > instead of an incrementing connectionId, you could also use the value > > of the this pointer? one le

Re: Review Request: use sqlite for storage

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5506/#review7926 --- the implementation looks good; my one question is regards keeping

Review Request: use sqlite for storage

2010-10-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5506/ --- Review request for Plasma. Summary --- looking at how slow kconfig as,