Re: Review Request: kdebase runner syntax

2009-03-22 Thread Dario Freddi
First things first: the new patch looks great, then On Saturday 21 March 2009 20:37:53 Aaron J. Seigo wrote: > > it might also be interesting to note what kind of information is in the > search term .. numbers, words, etc? > One possible way could be a setExampleValue(const QVariant &value). This

Re: Review Request: kdebase runner syntax

2009-03-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/373/ --- (Updated 2009-03-21 14:06:55.122599) Review request for Plasma. Changes ---

Re: Review Request: kdebase runner syntax

2009-03-21 Thread Aaron J. Seigo
On Saturday 21 March 2009, Dario Freddi wrote: > Another thing: we shouldn't let :q: always translate to "search term": for > example, the powerdevil runner lets you enter screen brightness > , and having the user read "screen brightness " > can be confusing. > > Apart from PowerDevil, each runner

Re: Review Request: kdebase runner syntax

2009-03-21 Thread Aaron J. Seigo
On Saturday 21 March 2009, Dario Freddi wrote: > A syntax can have unlimited examples but one single description. This is > the only weird point to me. I don't really get when I should add another > example to the syntax or a completely different syntax, since I can > document only a syntax, and no

Re: Review Request: kdebase runner syntax

2009-03-21 Thread Dario Freddi
Another thing: we shouldn't let :q: always translate to "search term": for example, the powerdevil runner lets you enter screen brightness , and having the user read "screen brightness " can be confusing. Apart from PowerDevil, each runner that triggers an action with a parameter would actually

Re: Review Request: kdebase runner syntax

2009-03-21 Thread Dario Freddi
Hello, This patch is really some great stuff, since it is the really needed first step to build docs for KRunners. Though, I have one main concern about the example syntaxes and description. A syntax can have unlimited examples but one single description. This is the only weird point to me. I

Re: Review Request: kdebase runner syntax

2009-03-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/373/ --- (Updated 2009-03-21 10:10:49.543387) Review request for Plasma. Changes ---

Review Request: kdebase runner syntax

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/373/ --- Review request for Plasma. Summary --- Patch provides syntax registration fo