Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Sebastian Kügler
On Friday 12 September 2008 16:55:14 Aaron J. Seigo wrote: > +setIcon(QIcon()); > > then you need to set up your applet properly yourself. try moving the > resize(128, 128) to after the setIcon call. That seems to be it, thanks! :) (Now on to finding out why the popup doesn't show up :>) --

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Rob Scheepmaker
On Friday 12 September 2008 16:12:09 Marco Martin wrote: > digital and analog clock, popup actually works now ;) > still one issue: when is on desktop it seems the whole dialog is not a > window but seems to become a proxywidget, even if dialog doesn't have the > applet as parent, really don't unde

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Sebastian Kügler
On Friday 12 September 2008 16:46:01 Marco Martin wrote: >  setMaximumSize(QWIDGETSIZE_MAX, QWIDGETSIZE_MAX); That helps (it's not perfect, but neither is the battery in its current state, it's quite broken actually :)). Most important to me is that I can get on with the code. Thanks for the ver

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Aaron J. Seigo
On Friday 12 September 2008, Sebastian Kügler wrote: > On Tuesday 09 September 2008 21:46:52 Marco Martin wrote: > > the patch on popupapplet is derived from the aaron's one > > and the clock uses it > > thing that i noted: icon() badly clash with Applet::icon() (that's even > > not virtual) it's r

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Marco Martin
On Friday 12 September 2008, Sebastian Kügler wrote: > On Tuesday 09 September 2008 21:46:52 Marco Martin wrote: > > the patch on popupapplet is derived from the aaron's one > > and the clock uses it > > thing that i noted: icon() badly clash with Applet::icon() (that's even > > not virtual) it's r

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/182/ --- (Updated 2008-09-12 07:12:09.122283) Review request for Plasma. Summary -

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Sebastian Kügler
On Tuesday 09 September 2008 21:46:52 Marco Martin wrote: > the patch on popupapplet is derived from the aaron's one > and the clock uses it > thing that i noted: icon() badly clash with Applet::icon() (that's even not > virtual) it's really not the same thing, should have a different name > perhap

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/182/#review188 --- Ship it! Code looks good to me. After the naming change (popupIco

Review Request: icon-less popupapplets and popupappletified clock

2008-09-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/182/ --- Review request for Plasma. Summary --- the patch on popupapplet is der