----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/182/ -----------------------------------------------------------
Review request for Plasma. Summary ------- the patch on popupapplet is derived from the aaron's one and the clock uses it thing that i noted: icon() badly clash with Applet::icon() (that's even not virtual) it's really not the same thing, should have a different name perhaps? Diffs ----- /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp /trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.cpp /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.h /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp Diff: http://reviewboard.vidsolbach.de/r/182/diff Testing ------- digital and analog clock, popup actually works now ;) still one issue: when is on desktop it seems the whole dialog is not a window but seems to become a proxywidget, even if dialog doesn't have the applet as parent, really don't understand this thing... Thanks, Marco _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
