Re: Review Request: custom toolbox support

2010-01-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1861/ --- (Updated 2010-01-24 17:44:51.335774) Review request for Plasma. Summary --

Re: Review Request: custom toolbox support

2009-10-19 Thread Marco Martin
> On 2009-10-19 21:27:14, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/toolbox.h, lines 71-72 > > > > > > this is actually a pretty poor name that we've kept only because it's > > an internal API ;) > > > >

Re: Review Request: custom toolbox support

2009-10-19 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1861/#review2720 --- /trunk/KDE/kdelibs/plasma/containment.cpp

Re: Review Request: custom toolbox support

2009-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1861/ --- (Updated 2009-10-17 21:48:21.172052) Review request for Plasma. Changes --

Re: Review Request: custom toolbox support

2009-10-17 Thread Marco Martin
> On 2009-10-16 17:29:58, Aaron Seigo wrote: > > the internal toolbox should just move to the properties system as well, and > > then we don't need two pointers, two code paths, etc. > > > > the only trick will be hooking up "addToolBoxAction" properly. options are: > > we export a basic ToolB

Re: Review Request: custom toolbox support

2009-10-16 Thread Aaron Seigo
> On 2009-10-16 17:29:58, Aaron Seigo wrote: > > the internal toolbox should just move to the properties system as well, and > > then we don't need two pointers, two code paths, etc. > > > > the only trick will be hooking up "addToolBoxAction" properly. options are: > > we export a basic ToolB

Re: Review Request: custom toolbox support

2009-10-16 Thread Marco Martin
> On 2009-10-16 17:29:58, Aaron Seigo wrote: > > the internal toolbox should just move to the properties system as well, and > > then we don't need two pointers, two code paths, etc. > > > > the only trick will be hooking up "addToolBoxAction" properly. options are: > > we export a basic ToolB

Re: Review Request: custom toolbox support

2009-10-16 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1861/#review2669 --- the internal toolbox should just move to the properties system as well

Review Request: custom toolbox support

2009-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1861/ --- Review request for Plasma. Summary --- this adds a setToolboxItem function.