Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/#review4261 --- Ship it! - Aaron On 2010-02-23 12:46:46, Vincenzo Di Massa wrote: >

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
> On 2010-02-23 15:12:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, lines 150-153 > > > > > > Applet::init() should definitely be called in the if (!isContainment()) > > block, but Applet::init()

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Richard Dale
> On 2010-02-23 15:12:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, lines 150-153 > > > > > > Applet::init() should definitely be called in the if (!isContainment()) > > block, but Applet::init()

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/#review4252 --- /trunk/KDE/kdelibs/plasma/containment.cpp

Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Vincenzo Di Massa
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/ --- Review request for Plasma. Summary --- Can this be harmful? I think this co