Re: Review Request: WebView Kinetic Scrolling

2009-10-04 Thread Marco Martin
On Sunday 04 October 2009, Kenneth Christiansen wrote: > > this whas added to achieve scrolling by flicking (even in an animate way, > > by dragging fastly the webview and "launching" it) > > right now is done by a private class (right now with timers, will be > > ported to kinetic) that sets the s

Re: Review Request: WebView Kinetic Scrolling

2009-10-04 Thread Kenneth Christiansen
> this whas added to achieve scrolling by flicking (even in an animate way, by > dragging fastly the webview and "launching" it) > right now is done by a private class (right now with timers, will be ported to > kinetic) that sets the scrollvalue properties to achieve that. > seems a sane approach?

Re: Review Request: WebView Kinetic Scrolling

2009-10-04 Thread Marco Martin
On Sunday 04 October 2009, Kenneth Christiansen wrote: > > api wise of course it doesn't have much, because as our plasma one just > > wraps the most useful functions of qwebframe and qwebpage,, however just > > taking a quick look... > > I saw that you have added some extra API like setHorizontalS

Re: Review Request: WebView Kinetic Scrolling

2009-10-03 Thread Kenneth Christiansen
> api wise of course it doesn't have much, because as our plasma one just wraps > the most useful functions of qwebframe and qwebpage,, however just taking a > quick look... I saw that you have added some extra API like setHorizontalScroll or something similar. If you have some extra methods that

Review Request: WebView Kinetic Scrolling

2009-10-03 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1764/ --- Review request for Plasma, Aaron Seigo, Marco Martin, and Adenilson Cavalcanti.

Re: Review Request: WebView Kinetic Scrolling

2009-10-03 Thread Marco Martin
On Saturday 03 October 2009, Kenneth Christiansen wrote: > Would be cool if you guys could have a look at the QGraphicsWebView in > WebKit trunk, so we can get feedback on the API before we release it > with Qt 4.6. api wise of course it doesn't have much, because as our plasma one just wraps the

Re: Review Request: WebView Kinetic Scrolling

2009-10-03 Thread Kenneth Christiansen
Would be cool if you guys could have a look at the QGraphicsWebView in WebKit trunk, so we can get feedback on the API before we release it with Qt 4.6. Cheers, Kenneth On Sat, Oct 3, 2009 at 10:16 AM, Marco Martin wrote: > > --- > This is

Re: Review Request: WebView Kinetic Scrolling

2009-10-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1764/#review2534 --- Ship it! apart a couple of stye issues it's ok trunk/KDE/kdelibs/pl