Would be cool if you guys could have a look at the QGraphicsWebView in WebKit trunk, so we can get feedback on the API before we release it with Qt 4.6.
Cheers, Kenneth On Sat, Oct 3, 2009 at 10:16 AM, Marco Martin <notm...@gmail.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1764/#review2534 > ----------------------------------------------------------- > > Ship it! > > > apart a couple of stye issues it's ok > > > trunk/KDE/kdelibs/plasma/widgets/webview.cpp > <http://reviewboard.kde.org/r/1764/#comment1859> > > if (event->pos().x() > > > > trunk/KDE/kdelibs/plasma/widgets/webview.cpp > <http://reviewboard.kde.org/r/1764/#comment1860> > > if (me.isAccepted()) { > > > > trunk/KDE/kdelibs/plasma/widgets/webview.cpp > <http://reviewboard.kde.org/r/1764/#comment1861> > > also there, no spaces > > > - Marco > > > On 2009-10-03 13:07:41, igorto wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/1764/ >> ----------------------------------------------------------- >> >> (Updated 2009-10-03 13:07:41) >> >> >> Review request for Plasma, Aaron Seigo, Marco Martin, and Adenilson >> Cavalcanti. >> >> >> Summary >> ------- >> >> Add support for kinetic scrolling in webview widget. >> >> TODO: >> >> -Make Horizontal Kinetic Scrolling works >> >> >> Diffs >> ----- >> >> trunk/KDE/kdelibs/plasma/widgets/webview.h 1030897 >> trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1030897 >> >> Diff: http://reviewboard.kde.org/r/1764/diff >> >> >> Testing >> ------- >> >> webbrowser >> >> >> Thanks, >> >> igorto >> >> > > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Kenneth Rohde Christiansen Technical Lead / Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
