Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Giulio Camuffo
> On 2009-10-06 10:16:00, Jacopo De Simoi wrote: > > /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp, > > line 152 > > > > > > Here we should make sure to hide() the description Label; > > wrote:

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Jacopo De Simoi
> On 2009-10-06 10:16:00, Jacopo De Simoi wrote: > > /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp, > > line 390 > > > > > > Now that the left(hehe)action stays activated when !isCollapsed() we

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Aaron Seigo
> On 2009-10-06 10:16:00, Jacopo De Simoi wrote: > > /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp, > > line 390 > > > > > > Now that the left(hehe)action stays activated when !isCollapsed() we

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/#review2562 --- Ship it! I'm finally convinced, we need to fix some issues here and t

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-05 Thread Aaron Seigo
> On 2009-10-06 02:00:26, Chani wrote: > > /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.cpp, > > line 489 > > > > > > commented out code... is it dead? should it be removed? yes, removed now in

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-05 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/#review2559 --- Ship it! I'm a little fuzzy on what's going on with the two items nea

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/ --- (Updated 2009-10-05 23:27:10.347412) Review request for Plasma, Jacopo De Simoi

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/ --- (Updated 2009-10-05 18:49:28.837661) Review request for Plasma, Jacopo De Simoi

Review Request: Unified ItemBackground in new Device Notifier

2009-10-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/ --- Review request for Plasma, Jacopo De Simoi and Giulio Camuffo. Summary ---