----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/#review2559 -----------------------------------------------------------
Ship it! I'm a little fuzzy on what's going on with the two items near the end; my brain seems to have just run out of power halfway through :) /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.h <http://reviewboard.kde.org/r/1790/#comment1872> grammar! /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.h <http://reviewboard.kde.org/r/1790/#comment1873> there are two of them now, with the exact same comment. can you change the comment to explain how they're different? /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.cpp <http://reviewboard.kde.org/r/1790/#comment1874> commented out code... is it dead? should it be removed? - Chani On 2009-10-05 23:27:10, Aaron Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1790/ > ----------------------------------------------------------- > > (Updated 2009-10-05 23:27:10) > > > Review request for Plasma, Jacopo De Simoi and Giulio Camuffo. > > > Summary > ------- > > proof of concept showing how the item background could be unified into > NotifierDialog; requires today's libplasma for fixes to the ItemBackground > widget > > > Diffs > ----- > > /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.h > 1031762 > /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp > 1031762 > /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.h > 1031762 > /trunk/kdereview/plasma/applets/devicenotifier-refactor/notifierdialog.cpp > 1031762 > > Diff: http://reviewboard.kde.org/r/1790/diff > > > Testing > ------- > > > Thanks, > > Aaron > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
