Re: [Kde-pim] Review Request: Ported KTimeTracker to KNotification

2009-09-29 Thread Aaron J. Seigo
On September 29, 2009, Ingo Klöcker wrote: > On Tuesday 29 September 2009, thors...@staerk.de wrote: > > >> On 2009-09-29 05:32:23, Thorsten Staerk wrote: > > >> > I committed the change, see > > >> > > >> http://websvn.kde.org/?view=revision&revision=1029142. Where can I > > >> set this to complet

Re: [Kde-pim] Review Request: Ported KTimeTracker to KNotification

2009-09-29 Thread Ingo Klöcker
On Tuesday 29 September 2009, thors...@staerk.de wrote: > >> On 2009-09-29 05:32:23, Thorsten Staerk wrote: > >> > I committed the change, see > >> > >> http://websvn.kde.org/?view=revision&revision=1029142. Where can I > >> set this to completed? > > > > there is somewhere a button here that lets

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-29 Thread Aaron J. Seigo
On September 29, 2009, thors...@staerk.de wrote: > >> On 2009-09-29 05:32:23, Thorsten Staerk wrote: > >> > I committed the change, see > >> > >> http://websvn.kde.org/?view=revision&revision=1029142. Where can I set > >> this to completed? > > > > there is somewhere a button here that lets you set

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-29 Thread thorsten
> > >> On 2009-09-29 05:32:23, Thorsten Staerk wrote: >> > I committed the change, see >> http://websvn.kde.org/?view=revision&revision=1029142. Where can I set >> this to completed? > > there is somewhere a button here that lets you set this to submitted. > Do you mean the "ship it" tag? I did set

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Beat Wolf
> On 2009-09-29 05:32:23, Thorsten Staerk wrote: > > I committed the change, see > > http://websvn.kde.org/?view=revision&revision=1029142. Where can I set this > > to completed? there is somewhere a button here that lets you set this to submitted. - Beat --

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Thorsten Staerk
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2495 --- Ship it! I committed the change, see http://websvn.kde.org/?view=rev

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Aaron Seigo
> On 2009-09-28 19:13:17, Thorsten Staerk wrote: > > I dislike if libraries change, like this change from KSystemTray to > > KNotification or however this is called ... > > > > Here is your patch as I would like to commit: > > > > emTrayIcon( 0 )

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Thorsten Staerk
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2487 --- I dislike if libraries change, like this change from KSystemTray to K

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Davide Bettio
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can find me in #plasma. > > Thorsten Staerk wrot

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-24 Thread Thorsten Staerk
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can find me in #plasma. > > Thorsten Staerk wrot

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-24 Thread Thorsten Staerk
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can find me in #plasma. Did not work - most impo

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-22 Thread Davide Bettio
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find me in #plasma. - Davide -

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-21 Thread Thorsten Staerk
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/#review2411 --- Good to see you working on my baby ktimetracker. Let's have a discussi

Review Request: Ported KTimeTracker to KNotification

2009-09-19 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1653/ --- Review request for KDE PIM and Plasma. Summary --- KTimeTracker has been po