On Tuesday 29 September 2009, thors...@staerk.de wrote: > >> On 2009-09-29 05:32:23, Thorsten Staerk wrote: > >> > I committed the change, see > >> > >> http://websvn.kde.org/?view=revision&revision=1029142. Where can I > >> set this to completed? > > > > there is somewhere a button here that lets you set this to > > submitted. > > Do you mean the "ship it" tag? I did set that.
No. AFAIK only the original submitter of the review request can close it. Regards, Ingo > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/1653/#review2495 > > ----------------------------------------------------------- > > > > On 2009-09-19 20:16:41, Davide Bettio wrote: > >> ----------------------------------------------------------- > >> This is an automatically generated e-mail. To reply, visit: > >> http://reviewboard.kde.org/r/1653/ > >> ----------------------------------------------------------- > >> > >> (Updated 2009-09-19 20:16:41) > >> > >> > >> Review request for KDE PIM and Plasma. > >> > >> > >> Summary > >> ------- > >> > >> KTimeTracker has been ported to KNotificationItem but I still have > >> few issues that I've corrected with #if 0. > >> It's not really clear to me how the notification works when > >> KTimeTracker is a KPart. > >> Anyway please don't use XPM pixmaps, use icons. > >> > >> > >> Diffs > >> ----- > >> > >> /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122 > >> /trunk/KDE/kdepim/ktimetracker/tray.h 1024122 > >> /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122 > >> > >> Diff: http://reviewboard.kde.org/r/1653/diff > >> > >> > >> Testing > >> ------- > >> > >> > >> Thanks, > >> > >> Davide > > _______________________________________________ > KDE PIM mailing list kde-...@kde.org > https://mail.kde.org/mailman/listinfo/kde-pim > KDE PIM home page at http://pim.kde.org/
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
