Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21894 --- This review has been submitted with commit 37f8bbdfd3a3dd5922b

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21628 --- Ship it! Good to go :) - Sebastian Kügler On Nov. 8, 2012,

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-08 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/ --- (Updated Nov. 8, 2012, 2:05 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21594 --- Ship it! Three niggles, otherwise good to go. Please fix those

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-07 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/ --- (Updated Nov. 7, 2012, 9:31 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Sebastian Kügler
> On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.h, line 42 > > > > > > add the bool visible also here > > Antonis Tsiapaliokas wrote: > Sorry but i don't get

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Antonis Tsiapaliokas
> On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.h, line 42 > > > > > > add the bool visible also here Sorry but i don't get you. Why should i put a bool paramete

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21450 --- this patch should disable the konsole widget from every plasmoi

Re: Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21444 --- plasmate/mainwindow.cpp

Review Request: Plasmate: Remove Python support for konsole previewer

2012-11-05 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/ --- Review request for Plasma. Description --- Right now the python bindi