> On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.h, line 42 > > <http://git.reviewboard.kde.org/r/107209/diff/1/?file=93718#file93718line42> > > > > add the bool visible also here > > Antonis Tsiapaliokas wrote: > Sorry but i don't get you. Why should i put a bool parameter? For a case > like the following or because it is a virtual method and the other previewers > will reimplemented? > > on true, it will show the konsolepreviewer all the times > and on the false, i will use the existing code which hides the konsole?
Yes, just add the bool parameter, so it's more future-safe. It's imaginable that if you hide the console, you might also show it, and the other way round. > On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.cpp, line 131 > > <http://git.reviewboard.kde.org/r/107209/diff/1/?file=93719#file93719line131> > > > > Can't we use Plasma::Package here? The finding of the metadata.desktop > > file is a bit clumsy as it relies on package internals. > > Antonis Tsiapaliokas wrote: > Plasma::Package is working only for QML based plasmoids... So what was > the best way which i find. Any suggestions? :) > > > > plasmate(10518)/libplasma Plasma::loadEngine: Couldn't load script engine > for language "python" ! error reported: "Could not find plugin 'Python > Widget' for application 'plasmate'" Hm, Python plasmoids are being shipped in packages as well, it should really work... Not sure what's going wrong there. > On Nov. 5, 2012, 3 p.m., Sebastian Kügler wrote: > > plasmate/previewer/plasmoid/previewcontainment.cpp, line 141 > > <http://git.reviewboard.kde.org/r/107209/diff/1/?file=93719#file93719line141> > > > > We need to be damn sure that this is the right item... > > Antonis Tsiapaliokas wrote: > then, i have to make all the items (konsole, previewer etc) private... > (m_konsole,m_previewer etc...) > > Any ideas? Yeah ... I think keeping a pointer of them around is better. Maybe use a QHash<QString, QWidget*> so we don't clutter the header too much? - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107209/#review21444 ----------------------------------------------------------- On Nov. 5, 2012, 2:25 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107209/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2012, 2:25 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Right now the python bindings doesn't support the kDebug, so the konsole > previewer cannot return any output. > Until this is fixed, we are disabling the python support for the konsole > previewer. > > > Diffs > ----- > > plasmate/mainwindow.h 6ac6fcd > plasmate/mainwindow.cpp 9c19658 > plasmate/previewer/plasmoid/previewcontainment.h 34dfb52 > plasmate/previewer/plasmoid/previewcontainment.cpp 266baa4 > plasmate/previewer/previewer.h 271bab8 > plasmate/previewer/previewer.cpp 6f07098 > > Diff: http://git.reviewboard.kde.org/r/107209/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
