Re: Review Request: New Applet handle system

2010-09-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5155/ --- (Updated 2010-09-04 17:44:10.408413) Review request for Plasma. Changes --

Re: Review Request: New Applet handle system

2010-09-04 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5155/ --- (Updated 2010-09-04 13:28:40.568518) Review request for Plasma, Aaron Seigo

Re: Review Request: New Applet handle system

2010-09-03 Thread Aaron Seigo
> On 2010-09-03 15:59:17, Aaron Seigo wrote: > > the patch does not apply cleanly to trunk; it needs to be updated / > > regenerated. > > > > instead of putting all of these classes into private/, i think it may make > > more sense to start a new dir in kdeliba/plasma/ called e.g. handles/, mu

Re: Review Request: New Applet handle system

2010-09-03 Thread Giulio Camuffo
> On 2010-09-03 15:59:17, Aaron Seigo wrote: > > the patch does not apply cleanly to trunk; it needs to be updated / > > regenerated. > > > > instead of putting all of these classes into private/, i think it may make > > more sense to start a new dir in kdeliba/plasma/ called e.g. handles/, mu

Re: Review Request: New Applet handle system

2010-09-03 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5155/#review7383 --- the patch does not apply cleanly to trunk; it needs to be updated

Re: Review Request: New Applet handle system

2010-09-01 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5155/ --- (Updated 2010-09-01 16:22:54.013035) Review request for Plasma, Aaron Seigo and

Re: Review Request: New Applet handle system

2010-09-01 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5155/ --- (Updated 2010-09-01 16:20:33.763003) Review request for Plasma and Aaron Seigo.

Re: Review Request: New Applet handle system

2010-09-01 Thread Marco Martin
> On 2010-08-31 11:27:51, Marco Martin wrote: > > trunk/KDE/kdelibs/plasma/private/abstracthandle.h, line 67 > > > > > > what is the exact use case for this function? > > Giulio Camuffo wrote: > It does all the cleani

Re: Review Request: New Applet handle system

2010-09-01 Thread Giulio Camuffo
> On 2010-08-31 11:27:51, Marco Martin wrote: > > i started with an api review of abstracthandle, will have to be done piece > > by piece because is really monster patch. > > (by the way, reviewboard still can't show the full diff, the patch should > > have been done with an old checkout proba

Re: Review Request: New Applet handle system

2010-08-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5155/#review7311 --- i started with an api review of abstracthandle, will have to be done p

Re: Review Request: New Applet handle system

2010-08-28 Thread Giulio Camuffo
> On 2010-08-27 15:57:53, Marco Martin wrote: > > doesn't seem to apply correctly it is svn diff that has some problems, it seems. try applying the patch with -p0 - Giulio --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: New Applet handle system

2010-08-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5155/#review7243 --- doesn't seem to apply correctly - Marco On 2010-08-26 10:30:18, Giu

Review Request: New Applet handle system

2010-08-26 Thread Giulio Camuffo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5155/ --- Review request for Plasma and Aaron Seigo. Summary --- This is a rewamp of