> On 2010-08-27 15:57:53, Marco Martin wrote: > > doesn't seem to apply correctly
it is svn diff that has some problems, it seems. try applying the patch with -p0 - Giulio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5155/#review7243 ----------------------------------------------------------- On 2010-08-26 10:30:18, Giulio Camuffo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5155/ > ----------------------------------------------------------- > > (Updated 2010-08-26 10:30:18) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > This is a rewamp of the Applet handle system. Through its modular > architecture it easily allows modifications and reuse of code. > > It features a base Handle class, AbstractHandle, and a base class for the > control elements, ControlElement. I developed an handle based on the actual > AppletHandle, DesktopHandle, and the control elements for the usual > operations. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/CMakeLists.txt 1168271 > trunk/KDE/kdelibs/plasma/applet.h 1168271 > trunk/KDE/kdelibs/plasma/applet.cpp 1168271 > trunk/KDE/kdelibs/plasma/containment.h 1168271 > trunk/KDE/kdelibs/plasma/containment.cpp 1168271 > trunk/KDE/kdelibs/plasma/extenders/extender.cpp 1168271 > trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1168271 > trunk/KDE/kdelibs/plasma/private/abstracthandle.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/abstracthandle.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/applet_p.h 1168271 > trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1168271 > trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1168271 > trunk/KDE/kdelibs/plasma/private/configurecontrol.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/configurecontrol.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/containment_p.h 1168271 > trunk/KDE/kdelibs/plasma/private/controlelement.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/controlelement.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/controlelement_p.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/desktophandle.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/desktophandle.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/maximizecontrol.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/maximizecontrol.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/movecontrol.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/movecontrol.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/removecontrol.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/removecontrol.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/resizecontrol.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/resizecontrol.cpp PRE-CREATION > trunk/KDE/kdelibs/plasma/private/rotatecontrol.h PRE-CREATION > trunk/KDE/kdelibs/plasma/private/rotatecontrol.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/5155/diff > > > Testing > ------- > > It isn't finished. It's missing the touch events management (which, however, > it's hard to me to do, 'cause i don't have any touch screen device) and a > better drag and drop system between containments. I'd like, however, to know > what you think about what i've done, especially about the architecture. > > What's here works, though. > > > Thanks, > > Giulio > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
