Re: Review Request: Fix layout problems in the pager applet

> On 2009-07-27 00:35:33, Aaron Seigo wrote: > > just found a "small" problem when doing some more testing before commit: > > when it's in a non horiz/vert form factor (e.g. planar, aka "the desktop") > > the size of the desktop bits don't scale down consistently to fit the > > width. you can

Re: Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1802 --- just found a "small" problem when doing some more testing before commi

Re: Review Request: Fix layout problems in the pager applet

> On 2009-07-27 00:08:35, Aaron Seigo wrote: > > ok, this looks safe enough .. pls commit this to trunk, let's test it > > thoroughly there, and then we can backport it if/when no problems arise. > > Anthony Bryant wrote: > Thanks! I don't actually have an svn account... Could you commit it

Re: Review Request: Fix layout problems in the pager applet

> On 2009-07-27 00:08:35, Aaron Seigo wrote: > > ok, this looks safe enough .. pls commit this to trunk, let's test it > > thoroughly there, and then we can backport it if/when no problems arise. Thanks! I don't actually have an svn account... Could you commit it for me? - Anthony -

Re: Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1799 --- Ship it! ok, this looks safe enough .. pls commit this to trunk, let'

Re: Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/ --- (Updated 2009-07-25 21:40:41.819952) Review request for Plasma. Changes --

Re: Review Request: Fix layout problems in the pager applet

> On 2009-07-25 08:56:47, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp, lines 147-150 > > > > > > these lines must not be removed; recalculateGeometry() may cause a > > change in the s

Re: Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/ --- (Updated 2009-07-25 14:03:16.312849) Review request for Plasma. Changes --

Re: Review Request: Fix layout problems in the pager applet

> On 2009-07-25 08:56:47, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp, lines 261-264 > > > > > > how well does this work with changing a panel from horizontal to > > vertical and back

Re: Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1761 --- /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp

Re: Review Request: Fix layout problems in the pager applet

> On 2009-07-25 01:46:48, michael wrote: > > I just opened a review request on the same topic. When I started working on > > it a few hours ago this request wasn't there yet and I didn't check again > > before publishing it... sorry about that. > > > > I didn't check all the calculations in yo

Re: Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1756 --- I just opened a review request on the same topic. When I started worki

Review Request: Fix layout problems in the pager applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/ --- Review request for Plasma. Summary --- This patch fixes a few problems with