> On 2009-07-25 01:46:48, michael wrote: > > I just opened a review request on the same topic. When I started working on > > it a few hours ago this request wasn't there yet and I didn't check again > > before publishing it... sorry about that. > > > > I didn't check all the calculations in your patch but I'm running it now > > and I don't see any problems. > > Well, except the issue with vertical and horizontal pagers that I tried to > > fix with my patch (http://reviewboard.kde.org/r/1123/) but that wasn't what > > you tried to fix. So I'd say commit it and I'll see if I can come up with > > an updated patch, depending on what people think about the issue.
Thanks for trying it! I think we added the patches within 2 minutes of each other, so there was no way of knowing really. I don't actually have an SVN account so I can't commit it myself. Also I'd like to hear whether it matters that I removed the code for ignoring some constraints events first. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1124/#review1756 ----------------------------------------------------------- On 2009-07-25 01:11:34, Anthony Bryant wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1124/ > ----------------------------------------------------------- > > (Updated 2009-07-25 01:11:34) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes a few problems with the pager that are especially apparent > in vertical panels. Specifically, the rows and columns are unnecessarily > swapped in recalculateGeometry() which causes bug 200013. > Also, due to the way the rectangle sizes were calculated it was possible for > certain areas to be clipped. This patch makes sure every item can fit into > the current space. > This also fixes a bug I only noticed when reading the code, where extra > unnecessary columns could be added if desktopCount % rows > 1 > > My main concern about this patch is that it removes a mechanism for ignoring > some constraints events, I think these events are needed in order to avoid > clipping some of the virtual desktops, but I'm not sure how to reproduce the > bug that made this filtering necessary in the first place. > > > This addresses bug 200013. > https://bugs.kde.org/show_bug.cgi?id=200013 > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h 1002081 > /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp 1002081 > > Diff: http://reviewboard.kde.org/r/1124/diff > > > Testing > ------- > > Tested in vertical and horizontal panels and on the desktop. > > > Thanks, > > Anthony > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
