Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-24 Thread Max Lin
2011/4/22 Aaron J. Seigo > On Thursday, April 21, 2011 23:19:18 Max Lin wrote: > > Sure! I am filling the request application form :) > > BTW, an additional question, I seem the question "Who supports this > > request?" in application form, is that necessary? > > yes. you can put my name. Hi Aa

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-22 Thread Aaron J. Seigo
On Thursday, April 21, 2011 23:19:18 Max Lin wrote: > Sure! I am filling the request application form :) > BTW, an additional question, I seem the question "Who supports this > request?" in application form, is that necessary? yes. you can put my name. -- Aaron J. Seigo humru othro a kohnu se GP

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
2011/4/21 Aaron J. Seigo > On Thursday, April 21, 2011 22:35:38 Max Lin wrote: > > Direct commit to git? but I haven't KDE git write access permission, do I > > ah, ok; i'll push this commit for you then :) > Thanks for your help. > > > need request developer access in KDE identity first? > >

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/#review2806 --- This review has been submitted with commit 805544113d8ce4d85807

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Aaron J. Seigo
On Thursday, April 21, 2011 22:35:38 Max Lin wrote: > Direct commit to git? but I haven't KDE git write access permission, do I ah, ok; i'll push this commit for you then :) > need request developer access in KDE identity first? > Where can I found the workflow that I can follow? yes, if you con

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
Direct commit to git? but I haven't KDE git write access permission, do I need request developer access in KDE identity first? Where can I found the workflow that I can follow? last time I contribute patch, I just attached it on bugzilla. Sorry for I am new to here, and thank you for your feedback

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Luca Beltrame
In data giovedì 21 aprile 2011 12:49:51, Max Lin ha scritto: > Thanks :) > Does means change status to "Submitted", I am new for use reviewboard. Put REVIEW: on a single line at the end of your commit message, and KDE's git hooks will take care of closing this review as submitted for you. signa

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
> On April 21, 2011, 12:16 p.m., Aaron J. Seigo wrote: > > please commit & push :) Thanks :) Does means change status to "Submitted", I am new for use reviewboard. - Max --- This is an automatically generated e-mail. To reply, visit: ht

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/#review2802 --- Ship it! please commit & push :) - Aaron J. On April 21, 201

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/ --- (Updated April 21, 2011, 8:40 a.m.) Review request for Plasma. Changes -

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-20 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/#review2767 --- Ship it! please fix up the small style issue; otherwise, nice c

Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-20 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/ --- Review request for Plasma. Summary --- Ignore save config again after