----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/#review2767 -----------------------------------------------------------
Ship it! please fix up the small style issue; otherwise, nice catch, thanks :) libs/plasmagenericshell/backgrounddialog.cpp <http://git.reviewboard.kde.org/r/101159/#comment2422> please include {}s; as in: if (!isButtonEnabled(Apply)) { return; } - Aaron J. On April 20, 2011, 3:37 a.m., Max Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101159/ > ----------------------------------------------------------- > > (Updated April 20, 2011, 3:37 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > Ignore save config again after click Ok button when Apply button disabled. On > Desktop Settings dialog with Slideshow mode, the image would not change again > when we click Ok button after we clicked Apply button. > > > This addresses bug 197654. > http://bugs.kde.org/show_bug.cgi?id=197654 > > > Diffs > ----- > > libs/plasmagenericshell/backgrounddialog.cpp 53ac05a > > Diff: http://git.reviewboard.kde.org/r/101159/diff > > > Testing > ------- > > It's works fine on my machine. > > > Thanks, > > Max > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
