Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Marco Martin
> On Nov. 9, 2012, 10:52 a.m., Aaron J. Seigo wrote: > > nice work :) it's really coming into a very good shape ... > > Dmitry Ashkadov wrote: > But there is one problem: property id of Plasma::Applet isn't a constant > for now, so, there are warnings in stdout. > > Aaron J. Seigo wrote: >

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Aaron J. Seigo
> On Nov. 9, 2012, 10:52 a.m., Aaron J. Seigo wrote: > > nice work :) it's really coming into a very good shape ... > > Dmitry Ashkadov wrote: > But there is one problem: property id of Plasma::Applet isn't a constant > for now, so, there are warnings in stdout. .. already fixed in kdelibs

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Dmitry Ashkadov
> On Nov. 9, 2012, 10:52 a.m., Aaron J. Seigo wrote: > > nice work :) it's really coming into a very good shape ... But there is one problem: property id of Plasma::Applet isn't a constant for now, so, there are warnings in stdout. - Dmitry --

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107262/#review21690 --- Ship it! loks a good simplification to me :) - Marco Martin

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107262/#review21689 --- Ship it! nice work :) it's really coming into a very good shap

Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107262/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --