> On Nov. 9, 2012, 10:52 a.m., Aaron J. Seigo wrote: > > nice work :) it's really coming into a very good shape ... > > Dmitry Ashkadov wrote: > But there is one problem: property id of Plasma::Applet isn't a constant > for now, so, there are warnings in stdout. > > Aaron J. Seigo wrote: > .. already fixed in kdelibs, and it is only a warning so nothing to worry > about.
ugly but shouldn't have any functional impact whatoever, since the property actually doesn't ever change already - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107262/#review21689 ----------------------------------------------------------- On Nov. 9, 2012, 9:59 a.m., Dmitry Ashkadov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107262/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2012, 9:59 a.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > Special class Plasmoid no more need, for QML code SystemTray::Applet is > sufficient > > > Diffs > ----- > > plasma/generic/applets/systemtray/CMakeLists.txt 78031fd > plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml 6d35beb > plasma/generic/applets/systemtray/package/contents/ui/main.qml d942fba > plasma/generic/applets/systemtray/ui/applet.h 30c6214 > plasma/generic/applets/systemtray/ui/applet.cpp ecac20c > plasma/generic/applets/systemtray/ui/plasmoid.h d0bbf61 > plasma/generic/applets/systemtray/ui/plasmoid.cpp 1491595 > > Diff: http://git.reviewboard.kde.org/r/107262/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Ashkadov > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
