Re: Review Request: Adding "Set Wallpaper Image" option in Picture frame

2011-03-17 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100764/ --- (Updated March 17, 2011, 2:21 p.m.) Review request for Plasma. Changes -

Re: Review Request: Adding "Set Wallpaper Image" option in Picture frame

2011-03-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100764/#review2012 --- Ship it! looks good; one small crash prevention issue, and then

Re: Review Request: Adding "Set Wallpaper Image" option in Picture frame

2011-03-03 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100764/ --- (Updated March 3, 2011, 6:56 p.m.) Review request for Plasma. Changes --

Re: Review Request: Adding "Set Wallpaper Image" option in Picture frame

2011-03-02 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100764/#review1741 --- applets/frame/frame.cpp

Review Request: Adding "Set Wallpaper Image" option in Picture frame

2011-02-27 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100764/ --- Review request for Plasma. Summary --- Adding "Set Wallpaper Image" f

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread Aaron J. Seigo
On Wednesday, January 26, 2011, todd rme wrote: > Right, that is exactly what I am suggesting. and it's now what Plasma::Containment does for drop handling. please test to see if it does indeed behave in a "least surprise" principle method in practice (it works for me :) we then need to do arou

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread todd rme
On Wed, Jan 26, 2011 at 1:57 PM, Shantanu Tushar Jha wrote: > > On Thu, Jan 27, 2011 at 12:06 AM, todd rme wrote: > >> >> On Wed, Jan 26, 2011 at 12:46 PM, Sinny Kumari wrote: >> >>> >>> >>> On Wed, Jan 26, 2011 at 10:13 PM, todd rme wrote: >>> On Wed, Jan 26, 2011 at 11:20 AM, Sinny Kumari

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread Aaron J. Seigo
On Wednesday, January 26, 2011, todd rme wrote: > I think the only way to do this properly is to let the plugins decide for > themselves how to handle pictures sent to them. If a plugin doesn't > provide a way to handle pictures, only then do you resort to changing the > plugin. that's actually h

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread Sinny Kumari
Right now, when an image is dragged and dropped to the Plasma Desktop there will be an option "Image". It sets that Image as wallpaper and changes modes to Image which is default mode. So, In order to maintain consistency I did the same thing. On Thu, Jan 27, 2011 at 12:06 AM, todd rme wrote: >

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread Shantanu Tushar Jha
Hi, I think we discussed (Aaron proposed the idea) about having a method using which we could ask a wallpaper plugin if it supports an Image-based wallpaper. If it says true, we just ask it to set the specified image, and if it doesn't, then we change the plugin to Image. What do you guys think?

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread todd rme
On Wed, Jan 26, 2011 at 12:46 PM, Sinny Kumari wrote: > > > > On Wed, Jan 26, 2011 at 10:13 PM, todd rme wrote: > >> On Wed, Jan 26, 2011 at 11:20 AM, Sinny Kumari wrote: >> >>>This is an automatically generated e-mail. To reply, visit: >>> http://svn.reviewboard.kde.org/r/6416/ >>> Review

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread Sinny Kumari
This Patch works for all cases. Suppose current wallpaper is virus. If User has images in Picture frame and if he likes to set the Picture frame Image as wallpaper image. He can do so. "set wallpaper Image" sets the current image as wallpaper image and Wallpaper Plugin will be set to Image. On Wed

Re: Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread todd rme
On Wed, Jan 26, 2011 at 11:20 AM, Sinny Kumari wrote: >This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6416/ > Review request for Plasma. > By Sinny Kumari. > Description > > Including this patch and other two (http://svn.reviewboard.kde.org/r/

Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

2011-01-26 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6416/ --- Review request for Plasma. Summary --- Including this patch and other t