On Wed, Jan 26, 2011 at 1:57 PM, Shantanu Tushar Jha <jhahon...@gmail.com>wrote:
> > On Thu, Jan 27, 2011 at 12:06 AM, todd rme <toddrme2...@gmail.com> wrote: > >> >> On Wed, Jan 26, 2011 at 12:46 PM, Sinny Kumari <ksi...@gmail.com> wrote: >> >>> >>> >>> On Wed, Jan 26, 2011 at 10:13 PM, todd rme <toddrme2...@gmail.com>wrote: >>> >>>> On Wed, Jan 26, 2011 at 11:20 AM, Sinny Kumari <ksi...@gmail.com>wrote: >>>> >>>>> This is an automatically generated e-mail. To reply, visit: >>>>> http://svn.reviewboard.kde.org/r/6416/ >>>>> Review request for Plasma. >>>>> By Sinny Kumari. >>>>> Description >>>>> >>>>> Including this patch and other two >>>>> (http://svn.reviewboard.kde.org/r/6375/ , >>>>> http://reviewboard.kde.org/r/6391/ ) , It adds "Set Wallpaper Image" >>>>> feature in Picture Frame. If the User right clicks on Picture Frame, >>>>> there will be an option "Set Wallpaper Image". This Option will set the >>>>> current Image Of Picture >>>>> Frame as Wallpaper Image. >>>>> >>>>> Testing >>>>> >>>>> Setting Picture Frame Image as wallpaper Image in all cases. Added QTimer >>>>> in method Frame::setImageAsWallpaper() in Order to work properly in case >>>>> of Wallpaper other than Image and Slideshow. If there is better solution >>>>> than using QTimer, please suggest :) >>>>> >>>>> Diffs >>>>> >>>>> - trunk/KDE/kdeplasma-addons/applets/frame/frame.h (1216449) >>>>> - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp (1216449) >>>>> >>>>> View Diff <http://svn.reviewboard.kde.org/r/6416/diff/> >>>>> >>>>> _______________________________________________ >>>>> Plasma-devel mailing list >>>>> Plasma-devel@kde.org >>>>> https://mail.kde.org/mailman/listinfo/plasma-devel >>>>> >>>>> >>>> >>>> I see one issue with this approach: it hard-codes how to deal with >>>> different plugins. What happens to the weather wallpaper? What happens to >>>> wallpaper clock or day/night wallpaper? What if someone writes their own >>>> version of the slideshow plugin? Is someone going to rewrite this every >>>> time a new plugin is developed? >>>> >>>> Might it be a better approach to have some general API for setting >>>> images to a wallpaper? The plugin would set up its own method of dealing >>>> with the pictures sent to it (which could include ignoring it). The the >>>> default plugin and virus plugin would just set the image, the slideshow >>>> plugin would add it to the list, the weather plugin would set it to the >>>> current weather condition, the day/night and clock plugins would set it to >>>> the current time. >>>> >>>> As a fall-back, if the plugin does not support the API, plasma would >>>> change to the normal wallpaper image and use the image there. So plugins >>>> that don't use images, like marble and mandelbrot, could just not implement >>>> that API, in which case selecting an image would change to the default >>>> plugin and then set the image to that. >>>> >>>> This also has the benefit that other widgets would also be able to hook >>>> into this and change the wallpaper without much work and without worrying >>>> about what plugin is being used. >>>> >>>> -Todd >>>> >>>> _______________________________________________ >>>> Plasma-devel mailing list >>>> Plasma-devel@kde.org >>>> https://mail.kde.org/mailman/listinfo/plasma-devel >>>> >>>> >>> >>> This Patch works for all cases. Suppose current wallpaper is virus. If >>> User has images in Picture frame and if he likes to set the Picture frame >>> Image as wallpaper image. He can do so. "set wallpaper Image" sets the >>> current image as wallpaper image and Wallpaper Plugin will be set to Image. >>> >>> -- >>> http://www.sinny.in >>> >>> _______________________________________________ >>> Plasma-devel mailing list >>> Plasma-devel@kde.org >>> https://mail.kde.org/mailman/listinfo/plasma-devel >>> >>> >> Why should the plugin be set to image? I picked the virus plugin as an >> example because it uses an image as a wallpaper, but then manipulates the >> image. So if someone is using the virus wallpaper, and they select "set >> wallpaper Image", I think the expected behavior would be that the virus >> plugin starts using that image, not to change the plugin entirely. >> Similarly, if someone is using the weather wallpaper, and they select "set >> wallpaper Image", I think the expected behavior would be to use the image >> for the current weather, not to change the plugin. The same goes for the >> day/night wallpaper and the wallpaper clock. These all use images in >> various ways. I don't think people would be expecting this option to change >> the plugin, rather I think they would expect it to use the image in the >> plugin. >> >> Then you add situations I mentioned like someone making a photo montage >> wallpaper, which scatters a bunch of pictures over the desktop. Would you >> modify this function to deal with that properly, or would you erase their >> montage? >> >> I think the only way to do this properly is to let the plugins decide for >> themselves how to handle pictures sent to them. If a plugin doesn't provide >> a way to handle pictures, only then do you resort to changing the plugin. >> >> -Todd >> >> _______________________________________________ >> Plasma-devel mailing list >> Plasma-devel@kde.org >> https://mail.kde.org/mailman/listinfo/plasma-devel >> >> > > Hi, > > I think we discussed (Aaron proposed the idea) about having a method using > which we could ask a wallpaper plugin if it supports an Image-based > wallpaper. If it says true, we just ask it to set the specified image, and > if it doesn't, then we change the plugin to Image. > > What do you guys think? > > -- > > Shantanu Tushar (UTC +0530) > http://www.shantanutushar.com > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > Right, that is exactly what I am suggesting. -Todd
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
