Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19984 --- This review has been submitted with commit a74717fc5c9fd04d133

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19976 --- plasma/declarativeimports/plasmacomponents/qml/Button.qml

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19875 --- Ship it! looks good, just specify that those 2 properties are

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19873 --- Looks good to me. - Aurélien Gâteau On Oct. 3, 2012, 10:01 p

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

> On Oct. 4, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote: > > plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 104 > > > > > > unneeded change :) It is actually good practice to systematically use semi

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19870 --- I like it, it's a good step :) plasma/declarativeimports/plas

Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/ --- Review request for Plasma. Description --- Add minimumWidth and minim