----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19875 -----------------------------------------------------------
Ship it! looks good, just specify that those 2 properties are extensions plasma/declarativeimports/plasmacomponents/qml/Button.qml <http://git.reviewboard.kde.org/r/106717/#comment15781> only thing, those two properties are not available in other implementations such as meego or symbian components, so in the doc should mentioned they are extensions in plasma, not available in other components sets - Marco Martin On Oct. 3, 2012, 10:01 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106717/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2012, 10:01 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Add minimumWidth and minimumHeight properties to Plasma Button > > Rationale: > see mailing list threads "Button component width" and "Fit Grid elements in > Item" on plasma-devel > > > Diffs > ----- > > plasma/declarativeimports/plasmacomponents/qml/Button.qml 915ba66 > > Diff: http://git.reviewboard.kde.org/r/106717/diff/ > > > Testing > ------- > > Edited Widget gallery to have "width: minimumWidth" on a button. It looked ok. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
