Re: Review Request: Add CheckBox wrapper for Plasma toolbox

2009-03-29 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/428/#review706 --- Ship it! looks ok :) - Aaron On 2009-03-26 20:47:03, Alain Boyer wro

Re: Review Request: Add CheckBox wrapper for Plasma toolbox

2009-03-26 Thread Alain Boyer
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/428/ --- (Updated 2009-03-26 20:47:03.220349) Review request for Plasma. Changes ---

Re: Review Request: Add CheckBox wrapper for Plasma toolbox

2009-03-26 Thread Aaron Seigo
> On 2009-03-26 10:13:09, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp, line 43 > > > > > > can the pallete just be set in the ctor? or even better, just set when > > the checkbox is

Re: Review Request: Add CheckBox wrapper for Plasma toolbox

2009-03-26 Thread Alain Boyer
> On 2009-03-26 10:13:09, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp, line 43 > > > > > > can the pallete just be set in the ctor? or even better, just set when > > the checkbox is

Re: Review Request: Add CheckBox wrapper for Plasma toolbox

2009-03-26 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/428/#review628 --- yes, this needs to be fixed; they aren't using Plasma::Widgets because t

Review Request: Add CheckBox wrapper for Plasma toolbox

2009-03-26 Thread Alain Boyer
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/428/ --- Review request for Plasma. Summary --- This patch adds a wrapper around QChe