----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/428/#review706 -----------------------------------------------------------
Ship it! looks ok :) - Aaron On 2009-03-26 20:47:03, Alain Boyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/428/ > ----------------------------------------------------------- > > (Updated 2009-03-26 20:47:03) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds a wrapper around QCheckBox much like the current ToolButton > wrapper. The rational is that the existing label for "Different activity for > each desktop" is always displayed in black when zoomed out and using the > Oxygen Plasma theme. With this change, the label colour now respects > Plasma::Theme::TextColor. > > Is there any reason why we are not using the Plasma::CheckBox and > Plasma::PushButton widgets here? > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/shells/desktop/CMakeLists.txt 944909 > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.h PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 944909 > > Diff: http://reviewboard.kde.org/r/428/diff > > > Testing > ------- > > Switched between the Air and Oxygen themes and the label remains visible, > switching between black and white respectively. > > > Thanks, > > Alain > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
