Re: Incubation Request: Snap KCM / Review Request

2024-12-01 Thread scarlett . gately . moore
Hi all, I ask that snap-kcm please be reviewed as we are trying to include it in future plasma releases much like flatpak kcm is. I appreciate your time, Thanks, Scarlett On 10/15/24 06:50, Soumyadeep Ghosh wrote: Hi team, I would like to propose an incubation request for the Snap KCM. It

Re: KDE Review Request: KRDP

2024-05-22 Thread Akseli Lahtinen
Hi, the review period is over for KRDP and we'd like to officially include KRDP in 6.1. Here's the review request issue https://invent.kde.org/plasma/krdp/-/issues/17 Thanks! - Akseli Lahtinen On Friday 3 May 2024 21:07:55 GMT+3 Akseli Lahtinen wrote: > Hi! > > Arjen H

KDE Review Request: KRDP

2024-05-03 Thread Akseli Lahtinen
request issue: https://invent.kde.org/plasma/krdp/-/issues/17 I'd like to get some reviews in and so on so we can get this in good shape. :) Thank you! - Akseli Lahtinen PS. My first review request, do tell me if I missed something! I followed this documentation for it https://develop.kde.org

Re: Review Request: plasma-thunderbolt

2019-05-21 Thread Jonathan Riddell
On Wed, May 15, 2019 at 03:27:07PM +0200, Daniel Vrátil wrote: > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ultimately decided to better put it

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I initially submitted the code as a

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or if we can proceed to > > includ

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Albert Astals Cid
El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > Hi all, > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ulti

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Luca Beltrame
In data mercoledì 15 maggio 2019 15:27:07 CEST, Daniel Vrátil ha scritto: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. The repository at this point is m

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Friedrich W. H. Kossebau
Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. Pushed some small fixes to toplevel CMakeLis

Review Request: plasma-thunderbolt

2019-05-15 Thread Daniel Vrátil
Hi all, plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM for Plasma. I initially submitted the code as a patch against plasma-desktop [0], where it got reviewed, but it was ultimately decided to better put it into a separate repository, since it's not just a KCM but

Re: Review Request 121010: Keep track of notifications that were covered by a fullscreen window

2018-01-14 Thread Kai Uwe Broulik
oulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121010/ > --- > > (Updated Feb. 8, 2017, 11:35

Re: Review Request 130247: Show root items in kicker menu. Related to #358291

2017-11-14 Thread Christoph Feck
org/r/130247/ > --- > > (Updated Nov. 14, 2017, 1:29 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Show root items in kicker menu. Related to #358291 > &

Review Request 130247: Show root items in kicker menu. Related to #358291

2017-11-14 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130247/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 126322: [ToolTip] Dismiss tooltip when item becomes invisible

2017-08-29 Thread Kai Uwe Broulik
discarded. Review request for Plasma. Repository: plasma-framework Description --- When an item containing a tooltip becomes invisible the tooltip would stay there indefinitely. Diffs - src/declarativeimports/core/tooltip.h d38c49b src/declarativeimports/core/tooltip.cpp

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

2017-08-29 Thread Kai Uwe Broulik
discarded. Review request for Plasma. Repository: plasma-framework Description --- QMenu is smart enough not to position itself outside the screen, however this can mean that the button the Menu originated from, could be covered. This can be observed with Widget Explorer's &quo

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-08-03 Thread Gregor Mi
discarded. Review request for Plasma and KDE Usability. Repository: kinfocenter Description --- Add a new menu with a "Copy to Clipboard" action to the About System module. See screenshot. The action can be used to conveniently copy information when reporting a bug etc. Exam

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-08-03 Thread Gregor Mi
To reply, visit: > https://git.reviewboard.kde.org/r/130208/ > ----------- > > (Updated July 31, 2017, 7:44 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: kinfocenter > > > Description

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Gregor Mi
git.reviewboard.kde.org/r/130208/ > --- > > (Updated July 31, 2017, 7:44 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: kinfocenter > > > Description > --- > > Add a new menu wi

Re: Review Request 130206: systemsettings tooltip items non italic

2017-07-31 Thread Andreas Kainz
been marked as submitted. Review request for Plasma. Repository: systemsettings Description --- small change only to reduce visual differences. Tooltip header is bold, everything else is default font. Diffs - app/ToolTips/tooltipmanager.cpp e1c6e16 Diff: https

Re: Review Request 130205: View Styles

2017-07-31 Thread Andreas Kainz
been marked as submitted. Review request for Plasma. Repository: systemsettings Description --- as system settings has now 3 different views the classic should be removed from the tree view in configure dialogue. Diffs - classic/settings-classic-view.desktop 57cd2a3 Diff: https

Re: Review Request 130205: View Styles

2017-07-31 Thread Sebastian Kügler
.kde.org/r/130205/ > --- > > (Updated July 26, 2017, 9:54 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > as system settings has now 3 different views the classic should be removed > from the tree

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Sebastian Kügler
ewboard.kde.org/r/130208/ > --- > > (Updated July 31, 2017, 7:44 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: kinfocenter > > > Description > --- > > Add a

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Elvis Angelaccio
----------- > > (Updated July 31, 2017, 7:44 a.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: kinfocenter > > > Description > --- > > Add a new menu with a "Copy to Clipboard" action to the Ab

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-30 Thread Anthony Fieroni
or Mi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130208/ > --- > > (Updated Юли 30, 2017, 6:39 след обяд) &

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-30 Thread Gregor Mi
tically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130208/ > --- > > (Updated July 30, 2017, 3:39 p.m.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > De

Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-30 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/ --- Review request for Plasma. Repository: kinfocenter Description

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-29 Thread Jiri Bohac
marked as submitted. Review request for Plasma and Albert Astals Cid. Changes --- Submitted with commit 5668ff05ad8cfc027bbd9fe7692fc2be518649c6 by Albert Astals Cid on behalf of Jiri Bohac to branch master. Repository: plasma-workspace Description --- Update the list of country

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-28 Thread Sebastian Kügler
d Dec. 27, 2016, 5:48 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-workspace > > > Description > --- > > Update the list of country names to the current names in iso-codes > (as output by isoquery -c). > &g

Re: Review Request 130205: View Styles

2017-07-28 Thread Andreas Kainz
/#review103488 --- On Juli 26, 2017, 9:54 nachm., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130205

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-28 Thread Albert Astals Cid
Updated Dec. 27, 2016, 5:48 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-workspace > > > Description > --- > > Update the list of country names to the current names in iso-codes > (as output by isoquery -

Re: Review Request 130206: systemsettings tooltip items non italic

2017-07-28 Thread Sebastian Kügler
ted July 26, 2017, 10:14 p.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > --- > > small change only to reduce visual differences. Tooltip header is bold, > everything else is default font. > &g

Re: Review Request 130205: View Styles

2017-07-28 Thread Sebastian Kügler
9:54 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130205/ > --- > > (Updated July 26,

Review Request 130206: systemsettings tooltip items non italic

2017-07-26 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130206/ --- Review request for Plasma. Repository: systemsettings Description

Review Request 130205: View Styles

2017-07-26 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/ --- Review request for Plasma. Repository: systemsettings Description

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Eric Koegel
discarded. Review request for Plasma. Repository: kwin Description --- ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls required by Kwin to run under Wayland. This patch first looks for the login1 service before attempting the ConsoleKit service. Diffs

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Martin Flöser
his is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130163/ > --- > > (Updated June 19, 2017, 9:42 a.m.) > > > Review request for Plasma. > > &g

Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130163/ --- Review request for Plasma. Repository: kwin Description

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-17 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/ --- (Updated June 17, 2017, 1:58 p.m.) Review request for Plasma and Kåre

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-17 Thread Martin Koller
marked as submitted. Review request for Plasma and Kåre Särs. Bugs: 373776 http://bugs.kde.org/show_bug.cgi?id=373776 Repository: kdeplasma-addons Description --- See bug #373776 The CPU bars do not show a value when using separate bars per CPU, and the tooltip never shows a value

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Kåre Särs
6 p.m., Martin Koller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129838/ > --- > > (Updated Jan. 15, 2017, 2:36 p.m.)

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Kåre Särs
n. 15, 2017, 2:36 p.m.) > > > Review request for Plasma and Kåre Särs. > > > Bugs: 373776 > http://bugs.kde.org/show_bug.cgi?id=373776 > > > Repository: kdeplasma-addons > > > Description > --- > > See bug #373776 > The CPU bars do not

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Marco Martin
ted e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129838/ > --- > > (Updated Jan. 15, 2017, 2:36 p.m.) > > > Review request for Plasma and Kåre Särs. > > > Bugs: 373776 > http://bugs.

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Martin Koller
oard.kde.org/r/129838/ > --- > > (Updated Jan. 15, 2017, 2:36 p.m.) > > > Review request for Plasma and Kåre Särs. > > > Bugs: 373776 > http://bugs.kde.org/show_bug.cgi?id=373776 > > > Repository: kdeplas

Re: Review Request 130129: Don't upscale jpeg images when creating thumbnails

2017-06-03 Thread Alexander Volkov
marked as submitted. Review request for Plasma, Alex Bikadorov and Christoph Feck. Changes --- Submitted with commit b5e4e830bae2928b54a52fca26c3009e96fe2c56 by Alexander Volkov to branch master. Repository: kio-extras Description --- BUG: 379817 Diffs - thumbnail

Re: Review Request 130129: Don't upscale jpeg images when creating thumbnails

2017-06-03 Thread Christoph Feck
ated June 3, 2017, 11:28 a.m.) > > > Review request for Plasma, Alex Bikadorov and Christoph Feck. > > > Repository: kio-extras > > > Description > --- > > BUG: 379817 > > > Diffs > - > > thumbnail/jpegcreator.cpp e4c7f0e5efb

Review Request 130129: Don't upscale jpeg images when creating thumbnails

2017-06-03 Thread Alexander Volkov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130129/ --- Review request for Plasma, Alex Bikadorov and Christoph Feck. Repository

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

2017-05-14 Thread Alex Bikadorov
org/r/129851/ > --- > > (Updated Jan. 19, 2017, 1:06 p.m.) > > > Review request for Plasma. > > > Repository: kio-extras > > > Description > --- > > QImageReader::setScaledSize() allows to use fast downscaling > for jpeg images (by setting jpeg_decompr

Re: Review Request 130006: Avoid showing wrong timezone suffix in krunner time

2017-05-08 Thread Ronnie Thomas
discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- Krunner is suffixing the local timezone when asked for the time of other regions. QLocale doesn't provide a way to set the locale based only on the country (which is provided by QDateTime), so it wou

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
discarded. Review request for Plasma. Repository: plasma-integration Description --- Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work. Diffs - src/platformtheme/kdeplatformtheme.h 7835439 src/platformtheme/kdeplatformtheme.cpp 704f176 Diff: https

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > ------- > > (Updated April 21, 2017, 11:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-integration > > > Description > --- > > Implement QPlatfo

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Kai Uwe Broulik
1, 2017, 9:11 vorm., Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > --- > > (Updated April 21,

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > --- > > (Updated April 21, 2017, 11:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-int

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
org/r/130094/#review103073 --- On April 21, 2017, 11:11 a.m., Eugene Shalygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > ---

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Kai Uwe Broulik
is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > --- > > (Updated April 21, 2017, 9:11 vorm.) > > > Review request for Plasma. > > > Repository: pl

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > ----------- > > (Updated April 21, 2017, 11:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-integration > > > Description

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- (Updated April 21, 2017, 11:11 a.m.) Review request for Plasma

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Mark Gaiser
lygin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > --- > > (Updated apr 21, 2017, 8:04

Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- Review request for Plasma. Repository: plasma-integration Description

Review Request 130030: taskmanager : Implement window group dragging

2017-03-19 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130030/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-03-19 Thread Martin Koller
--- On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129838/ > ---

Review Request 130006: Avoid showing wrong timezone suffix in krunner time

2017-03-11 Thread Ronnie Thomas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130006/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-08 Thread Leslie Zhai
marked as submitted. Review request for Plasma, Kai Uwe Broulik and David Edmundson. Changes --- Submitted with commit 2b7ef97f8104db6212e2a75d2578c6edca96e05a by Leslie Zhai to branch master. Repository: plasma-workspace Description --- Hi KDE developer, Bug reported by the clang

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-08 Thread David Edmundson
d March 8, 2017, 2:17 a.m.) > > > Review request for Plasma, Kai Uwe Broulik and David Edmundson. > > > Repository: plasma-workspace > > > Description > --- > > Hi KDE developer, > > Bug reported by the clang static analyzer. > > Descriptio

Re: Review Request 129995: Fix KillRunner Memory leak

2017-03-07 Thread Leslie Zhai
marked as submitted. Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik. Changes --- Submitted with commit 55237430bdab1bfbbfb442281ca5e34f5eb5e212 by Leslie Zhai to branch master. Repository: plasma-workspace Description --- Hi KDE developers, Bug reported by the

Re: Review Request 129995: Fix KillRunner Memory leak

2017-03-07 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- (Updated 三月 8, 2017, 10:42 a.m.) Review request for Plasma, Aleix Pol

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Leslie Zhai
> --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129994/ > --- > > (Updated 三月 8, 2017, 10:17 a.m.) > >

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated 三月 8, 2017, 10:17 a.m.) Review request for Plasma, Kai Uwe

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Kai Uwe Broulik
o reply, visit: > https://git.reviewboard.kde.org/r/129994/ > --- > > (Updated März 7, 2017, 6:48 vorm.) > > > Review request for Plasma, Kai Uwe Broulik and David Edmundson. > > > Repository: plasma-workspac

Re: Review Request 129995: Fix KillRunner Memory leak

2017-03-07 Thread David Edmundson
Zhai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129995/ > --- > > (Updated March 7, 2017, 7:15

Review Request 129995: Fix KillRunner Memory leak

2017-03-06 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik

Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-06 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- Review request for Plasma, Kai Uwe Broulik and David Edmundson

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2017-03-03 Thread Aleix Pol Gonzalez
discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Only update the properties that require a winId when visible, otherwise let updateVisibility() take care about them. Diffs - src/plasmaquick/dialog.cpp 7bb63c5 Diff: https

Re: Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

2017-03-03 Thread Aleix Pol Gonzalez
discarded. Review request for Plasma. Repository: plasma-workspace Description --- * Remove the initial call to `PanelShadows::self()->addWindow(this);`. It ends up in a winId call that will force a premature construction of the QPlatformWindow. * Only update window properties w

Re: Review Request 126946: Remove specific X11 code

2017-03-01 Thread Anthony Fieroni
discarded. Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin. Repository: kdeplasma-addons Description --- Activity pager settings -> Selecting current desktop -> showDesktop. If desktop is showed by clicking on widget, it can be restored by clicking on i

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2017-02-28 Thread David Edmundson
discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Qt has two shaders for all items; one for when running OpenGL3.2+ without backwards compatibility (i.e running CoreProfile) and one that supports more legacy systems. (see the shaders

Re: Review Request 123300: Make the dataengine alignment timer more precise

2017-02-25 Thread Martin Klapetek
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 2fea7077c84b97028a424d3e1d66f9838ccf9201 by Albert Astals Cid on behalf of Martin Klapetek to branch master. Repository: plasma-framework Description --- It can and does happen that in case of two

Re: Review Request 126946: Remove specific X11 code

2017-02-25 Thread Albert Astals Cid
> > (Updated Feb. 6, 2016, 2:57 p.m.) > > > Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin. > > > Repository: kdeplasma-addons > > > Description > --- > > Activity pager settings -> Selecting current desktop -> s

Re: Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

2017-02-25 Thread Albert Astals Cid
ch 17, 2016, 2:16 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > * Remove the initial call to `PanelShadows::self()->addWindow(this);`. It > ends up in a winId call that will force a premature

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2017-02-25 Thread Albert Astals Cid
.kde.org/r/127409/ > --- > > (Updated March 17, 2016, 2:13 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Only update the properties that require a win

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-23 Thread Pascal VITOUX
marked as submitted. Review request for kde-workspace and Plasma. Changes --- Submitted with commit 9b2d766b2bb41a6725b585eaa8ca11fc9cf36b36 by David Edmundson on behalf of Pascal VITOUX to branch master. Repository: kdeplasma-addons Description --- Add a cache monitor to the

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-22 Thread Pascal VITOUX
d e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129917/ > --- > > (Updated fév. 7, 2017, 10:20 matin) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons >

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread David Edmundson
ed Feb. 7, 2017, 9:20 a.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and > 'cach

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread Albert Astals Cid
org/r/129917/ > --- > > (Updated Feb. 7, 2017, 9:20 a.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > Add a cache monitor to the System Load Viewer applet using 'ca

Re: Review Request 129955: fix off by one in the socket filename

2017-02-16 Thread Damjan Georgievski
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit fa1fbc2568fdfcf3f6ffa7370c3d26a3a47b9a5e by Aleix Pol on behalf of Damjan Georgievski to branch Plasma/5.9. Repository: kwallet-pam Description --- from the snprintf man page: The

Re: Review Request 129955: fix off by one in the socket filename

2017-02-16 Thread Aleix Pol Gonzalez
rd.kde.org/r/129955/ > --- > > (Updated Feb. 17, 2017, 12:23 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kwallet-pam > > > Description > --- > > from

Re: Review Request 129955: fix off by one in the socket filename

2017-02-16 Thread Damjan Georgievski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/ --- (Updated Feb. 17, 2017, 12:23 a.m.) Review request for KDE Frameworks

Re: Review Request 129867: Complete oxygen look and feel

2017-02-08 Thread Anthony Fieroni
marked as submitted. Review request for Plasma, Hugo Pereira Da Costa and Marco Martin. Changes --- Submitted with commit dee50cfd16e67014d9c839c554549e0f36f2101a by Anthony Fieroni to branch Plasma/5.9. Repository: oxygen Description --- Applying oxygen in lookandfeel kcm should

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

2017-02-08 Thread Marco Martin
org/r/126016/ > --- > > (Updated Nov. 10, 2015, 6:54 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Previously the taskmanager library contained a special case logic for windows > of

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

2017-02-08 Thread Johan Ouwerkerk
discarded. Review request for Plasma. Repository: plasma-workspace Description --- Previously the taskmanager library contained a special case logic for windows of KDE-4 KCM modules (only). These modules were recognised by finding wmClass=Kcmshell4. This logic is extended to cover

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2017-02-08 Thread David Rosca
discarded. Review request for Plasma. Bugs: 343349 http://bugs.kde.org/show_bug.cgi?id=343349 Repository: plasma-framework Description --- For some fonts, QFontMetrics::boundingRect(QString) returns too high rect which makes the gridSize too big. It now returns correctly the actual

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2017-02-08 Thread Marco Martin
org/r/125773/ > --- > > (Updated Oct. 29, 2015, 6:16 p.m.) > > > Review request for Plasma. > > > Bugs: 343349 > http://bugs.kde.org/show_bug.cgi?id=343349 > > > Repository: plasma-framework > > > Description > --- > > For some font

Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

2017-02-08 Thread Antonis Tsiapaliokas
discarded. Review request for Plasma. Repository: plasma-desktop Description --- This patch ports the kcm fonts to QML. Diffs - kcms/fonts/CMakeLists.txt d73636e kcms/fonts/fonts.cpp 74da799 kcms/fonts/fonts.desktop 5b486ed kcms/fonts/fonts.h d98bbe2 kcms/fonts

Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

2017-02-08 Thread Marco Martin
org/r/123682/ > --- > > (Updated May 19, 2015, 2:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > This patch ports the kcm fonts to QML. > > > Diffs > - > > kc

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

2017-02-08 Thread Marco Martin
org/r/125199/ > --- > > (Updated Sept. 12, 2015, 3:36 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > As requested by the VDG. > Rationale being that starting with an empty

Re: Review Request 125198: by default do not restore the previous session on next login

2017-02-08 Thread Harald Sitter
discarded. Review request for Plasma. Repository: plasma-workspace Description --- As requested by the VDG. Rationale being that starting with an empty session all the time is substantially less aggressive than potentially starting a gazillion applications slowing down startup and greeting the

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

2017-02-08 Thread Harald Sitter
discarded. Review request for Plasma. Repository: plasma-desktop Description --- As requested by the VDG. Rationale being that starting with an empty session all the time is substantially less aggressive than potentially starting a gazillion applications slowing down startup and greeting

Re: Review Request 125198: by default do not restore the previous session on next login

2017-02-08 Thread Marco Martin
org/r/125198/ > --- > > (Updated Sept. 12, 2015, 3:37 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > As requested by the VDG. > Rationale being that starting with an empty

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

2017-02-08 Thread Andrey Bondrov
discarded. Review request for Plasma, KDE Usability and Eike Hein. Bugs: 365204 https://bugs.kde.org/show_bug.cgi?id=365204 Repository: plasma-desktop Description --- Likely kickoff should use icons from icon theme, not from plasma theme. https://bugs.kde.org/show_bug.cgi?id=365204

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

2017-02-08 Thread Marco Martin
org/r/128392/ > --- > > (Updated July 11, 2016, 10:51 a.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Bugs: 365204 > https://bugs.kde.org/show_bug.cgi?id=365204 > > > Repository: plasma-desktop > > > Description &g

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2017-02-08 Thread Nico Rodsevich
discarded. Review request for Plasma, David Edmundson and Marco Martin. Repository: plasma-framework Description --- Enables to set rules that extends the #current-color-scheme CSS style of the Svg in order to change the Svg's items with currentColor fill to the specified i

  1   2   3   4   5   6   7   8   9   10   >