-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/
-----------------------------------------------------------

(Updated Aug. 29, 2017, 8:57 nachm.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
-------

QMenu is smart enough not to position itself outside the screen, however this 
can mean that the button the Menu originated from, could be covered. This can 
be observed with Widget Explorer's "get more widgets" buttons.


Diffs
-----

  src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 

Diff: https://git.reviewboard.kde.org/r/126061/diff/


Testing
-------

Ran the menu.qml test and moved the window around, positioning seemed sane. 
Also Widget Explorer more menu now pops up to the top.

I subtract the Y from the position to not break the most common usecase of 
popup(0, height) to have the menu pop up below the button. Now it pops up above 
it, still glued to it as it should be.


Thanks,

Kai Uwe Broulik

Reply via email to