Re: Review Request 128760: Fix crash on exit

2016-09-25 Thread Arfrever Frehtes Taifersar Arahesis
> On Sept. 17, 2016, 9:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard > > Hugo Pereira Da Costa wrote: > Ping ? > Do people have commit rights ? Should I commit it myself ? > > Peter Wu wrote:

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/ --- (Updated Sept. 21, 2016, 12:19 p.m.) Status -- This change has been

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Peter Wu
> On Sept. 17, 2016, 11:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard > > Hugo Pereira Da Costa wrote: > Ping ? > Do people have commit rights ? Should I commit it myself ? I think you should

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Hugo Pereira Da Costa
> On Sept. 17, 2016, 9:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard Ping ? Do people have commit rights ? Should I commit it myself ? - Hugo ---

Re: Review Request 128760: Fix crash on exit

2016-09-17 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/#review99244 --- Ship it! Sorry for the delay ... for some reason I don't a

Re: Review Request 128760: Fix crash on exit

2016-09-16 Thread Peter Wu
> On Aug. 26, 2016, 6:22 a.m., Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > > > > > This must be not (!inited). > > However this is not proper fix. Correct and test patch in this way >

Re: Review Request 128760: Fix crash on exit

2016-08-27 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/ --- (Updated Aug. 27, 2016, 11:04 a.m.) Review request for Plasma, David Edmu