> On Sept. 17, 2016, 11:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard > > Hugo Pereira Da Costa wrote: > Ping ? > Do people have commit rights ? Should I commit it myself ?
I think you should commit it, same for https://git.reviewboard.kde.org/r/128761/ which is already marked as Ship it for 3 weeks. (I have no push rights.) - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/#review99244 ----------------------------------------------------------- On Aug. 27, 2016, 11:04 a.m., Peter Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128760/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2016, 11:04 a.m.) > > > Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da > Costa. > > > Bugs: 356940 > https://bugs.kde.org/show_bug.cgi?id=356940 > > > Repository: breeze > > > Description > ------- > > Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs > point to this delete-on-destroy hack which was added to avoid outliving > the plugin lifetime. > > This method is wrong because the returned style is owned by the caller > (QApplication, QProxyStyle, etc) and will cleaned up when those users > are destructed. > > > Diffs > ----- > > kstyle/breezestyleplugin.cpp 083100e > > Diff: https://git.reviewboard.kde.org/r/128760/diff/ > > > Testing > ------- > > Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit > and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer > crashes. Tested with Qt 5.7.0. > > > Thanks, > > Peter Wu > >
