Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
> On March 22, 2016, 5:28 p.m., Anthony Fieroni wrote: > > Ty. This is also needed for Oxygen. Also notice incorrect positioning > > systemsettings -> multimedia > > http://store.picbg.net/pubpic/8F/19/c92e06333aff8f19.png Incorrect positioning is another issue. It happens only when used from

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/#review93875 --- Ty. This is also needed for Oxygen. Also notice incorrect pos

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/ --- (Updated March 22, 2016, 4:25 p.m.) Status -- This change has been m

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/#review93869 --- Ship it! Ship It! - Hugo Pereira Da Costa On March 22,

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/ --- (Updated March 22, 2016, 3:05 p.m.) Review request for Plasma and Hugo Pe

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa
> On March 22, 2016, 2:54 p.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 5059 > > > > > > For clarity I would rather put it the other way around: > > > > if( isQtQuickControl()) > >

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
> On March 22, 2016, 2:54 p.m., Hugo Pereira Da Costa wrote: > > kstyle/breezestyle.cpp, line 5059 > > > > > > For clarity I would rather put it the other way around: > > > > if( isQtQuickControl()) > >

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/#review93866 --- kstyle/breezestyle.cpp (line 2905)

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/ --- (Updated March 22, 2016, 2:35 p.m.) Review request for Plasma and Hugo Pe

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/ --- (Updated March 22, 2016, 2:28 p.m.) Review request for Plasma and Hugo Pe

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127460/ --- (Updated March 22, 2016, 2:24 p.m.) Review request for Plasma and Hugo Pe