Re: Review Request 126301: Add protocol for server side decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/ --- (Updated Dec. 17, 2015, 12:30 p.m.) Status -- This change has been m

Re: Review Request 126301: Add protocol for server side decoration

> On Dec. 11, 2015, 1:54 p.m., Sebastian Kügler wrote: > > src/server/display.cpp, line 330 > > > > > > Also, I'm confused. > > > > you connect to d, so d ends up being [this], which you then don't use,

Re: Review Request 126301: Add protocol for server side decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89646 --- Ship it! Ship It! - Sebastian Kügler On Dec. 16, 2015, 11:

Re: Review Request 126301: Add protocol for server side decoration

> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote: > > src/server/CMakeLists.txt, line 100 > > > > > > I don't get the name here, maybe surface_decoration would be better? > > (It's not about the server, it'

Re: Review Request 126301: Add protocol for server side decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/ --- (Updated Dec. 16, 2015, 12:07 p.m.) Review request for Plasma and Sebasti

Re: Review Request 126301: Add protocol for server side decoration

> On Dec. 11, 2015, 2:54 p.m., Sebastian Kügler wrote: > > src/client/server_decoration.h, line 179 > > > > > > apidocs missing > > > > It would be useful to explain the modes here, and possibly mention

Re: Review Request 126301: Add protocol for server side decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89348 --- src/client/protocols/server-decoration.xml (line 22)

Re: Review Request 126301: Add protocol for server side decoration

> On Dec. 10, 2015, 3:54 p.m., Marco Martin wrote: > > src/client/protocols/server-decoration.xml, line 45 > > > > > > do clients have to explicitly call that with risks of leaks? > > Martin Gräßlin wrote: >

Re: Review Request 126301: Add protocol for server side decoration

> On Dec. 10, 2015, 2:54 p.m., Marco Martin wrote: > > src/client/protocols/server-decoration.xml, line 45 > > > > > > do clients have to explicitly call that with risks of leaks? > > Martin Gräßlin wrote: >

Re: Review Request 126301: Add protocol for server side decoration

> On Dec. 10, 2015, 3:54 p.m., Marco Martin wrote: > > src/client/protocols/server-decoration.xml, line 45 > > > > > > do clients have to explicitly call that with risks of leaks? sorry I don't get the question?

Re: Review Request 126301: Add protocol for server side decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89309 --- src/client/protocols/server-decoration.xml (line 45)

Re: Review Request 126301: Add protocol for server side decoration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89307 --- src/client/protocols/server-decoration.xml (line 38)