Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-03 Thread Mark Gaiser
> On dec 2, 2015, 11:36 p.m., Mark Gaiser wrote: > > I had this issue for quite a while! > > It's in bug #349669, i have high hopes that this change fixes my case as > > well :) > > > > Will try this out somewhere this weekend. > > Martin Klapetek wrote: > No, unfortunately this will not f

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-03 Thread Kai Uwe Broulik
> On Dez. 2, 2015, 11:36 nachm., Mark Gaiser wrote: > > I had this issue for quite a while! > > It's in bug #349669, i have high hopes that this change fixes my case as > > well :) > > > > Will try this out somewhere this weekend. > > Martin Klapetek wrote: > No, unfortunately this will no

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89070 --- I'm glad that you found a solution which works just in time fo

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/ --- (Updated Dec. 3, 2015, 4:11 a.m.) Status -- This change has been mar

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89068 --- Ship it! This fixes bug for me :) - Bhushan Shah On Dec. 3

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
> On Dec. 3, 2015, 12:36 a.m., Mark Gaiser wrote: > > I had this issue for quite a while! > > It's in bug #349669, i have high hopes that this change fixes my case as > > well :) > > > > Will try this out somewhere this weekend. No, unfortunately this will not fix this issue, but it is related

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89064 --- Ship it! I had this issue for quite a while! It's in bug #349

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89061 --- Ship it! Ship It! - David Edmundson On Dec. 2, 2015, 7:32

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/ --- (Updated Dec. 2, 2015, 8:32 p.m.) Review request for Plasma. Changes --

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread Martin Klapetek
> On Dec. 2, 2015, 5:17 p.m., David Edmundson wrote: > > applets/notifications/lib/notificationsapplet.cpp, line 46 > > > > > > what about when it's just "Left" or "Right" ? It's not, ever. http://paste.opensuse.

Re: Review Request 126221: Rework the notifications positioning a bit

2015-12-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89049 --- applets/notifications/lib/notificationsapplet.cpp (line 46) <